Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end markup doesn't update when Gutenberg updates #8015

Closed
maddisondesigns opened this issue Jul 18, 2018 · 6 comments
Closed

Front-end markup doesn't update when Gutenberg updates #8015

maddisondesigns opened this issue Jul 18, 2018 · 6 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Extensibility The ability to extend blocks or the editing experience [Type] Developer Documentation Documentation for developers [Type] Question Questions about the design or development of the editor.

Comments

@maddisondesigns
Copy link

Describe the bug
I had a test page that I had created months ago. On the page it had a Multi-Column block (among lots of others). Up until only recently, the Multi-Column block was using CSS Grid. Recently, this has now changed to use Flexbox and more importantly, the content for each column is contained within its own container/div.

Even though my Gutenberg plugin was up to date, when I viewed this page on the front-end, it was still using the old markup (i.e. The blocks for each column weren't in their own container/div). The markup only changed to the new format once the page was re-saved.

Hypothetically, what happens in say 5 years time, when some new css grid spec is all the rage and WP is updated to use this all-new fancy grid? Is my page that I created 5 year earlier, still going to use the old markup? Based on the what I just saw with my old page, it would. I shouldn't have to go back and re-save all my old pages so that the front-end markup updates.

Obviously the most logical answer is no, I wouldn't have to re-save my old pages. In that case though, why did I just have to resave my old page now before seeing the new markup? How is this going to be avoided once Gutenberg is in core?

Gutenberg 3.2.0

@GlennMartin1
Copy link

Related: #7825

Keep in mind that the Columns block is designated "beta," and as such it's reasonable that there may be breakage while in the beta period.

@designsimply designsimply added [Type] Question Questions about the design or development of the editor. Backwards Compatibility Issues or PRs that impact backwards compatability labels Jul 18, 2018
@danielbachhuber danielbachhuber added the [Feature] Extensibility The ability to extend blocks or the editing experience label Jul 18, 2018
@designsimply
Copy link
Member

Duplicate of #4849.

@f00d4tehg0dz
Copy link

f00d4tehg0dz commented Jul 18, 2018

Further to that discussion @maddisondesigns What happens when you have that block on 1,000 of pages. How will you update the block. Are you going to sit there and press "update" on every 1,000 pages?
@danielbachhuber is the intention to add this functionality to the extend api? I've personally hit a roadblock with not being able to update existing blocks with more functionality inside our save, return function.

@youknowriad
Copy link
Contributor

Let consolidate all the block validation, deprecation, migration discussions in a single issue #13611 thanks.

@maddisondesigns
Copy link
Author

@youknowriad

Let consolidate all the block validation, deprecation, migration discussions in a single issue #13611

#13611 is closed so it seem pretty pointless to add comments there. I presume you mean #7604

@youknowriad
Copy link
Contributor

yes, sorry for the confusion, I discovered the existence of #7604 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Extensibility The ability to extend blocks or the editing experience [Type] Developer Documentation Documentation for developers [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

7 participants