Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-line gallery captions are visually imbalanced. #8018

Closed
kjellr opened this issue Jul 18, 2018 · 0 comments
Closed

Multi-line gallery captions are visually imbalanced. #8018

kjellr opened this issue Jul 18, 2018 · 0 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 18, 2018

In multi-line captions, the bottom-most line appears closer to the bottom of the box than to the line of text above it. This creates uncomfortable visual tension on that last line, and pulls it away visually from the text above it.

Adding just a tiny amount of additional padding between the caption and the bottom of the box helps relieve that:

screen shot 2018-07-18 at 8 37 58 am
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jul 18, 2018
@kjellr kjellr mentioned this issue Jul 30, 2018
Closed
12 tasks
@johnwatkins0 johnwatkins0 mentioned this issue Aug 3, 2018
Closed
@Soean Soean added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Oct 26, 2018
@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label Dec 3, 2018
kjellr added a commit that referenced this issue Jan 31, 2019
@kjellr
Increase bottom padding on gallery image caption
93549f8 
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
@kjellr kjellr mentioned this issue Jan 31, 2019
Merged
gziolo pushed a commit that referenced this issue Feb 1, 2019
@kjellr @gziolo
Increase bottom padding on gallery image caption (#13623)
2009bdd 
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@kjellr @youknowriad
Increase bottom padding on gallery image caption (#13623)
77480ae 
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@kjellr @youknowriad
Increase bottom padding on gallery image caption (#13623)
c5cdaf3 
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Increase bottom padding on gallery image caption
4 participants
@Soean @designsimply @kjellr @jorgefilipecosta