-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Block: Playlist #805
Comments
Is the idea this is both video and audio? To make sure we have the same as existing editor we would need to have both video and audio playlists. |
I never liked how it force itself to use 100% article content width. And it is most used case an User will put it in the Post. Playlist is perfect for sidebars, widgets. And maybe some list of podcasts in Posts. Not even then it looks nice enlarged to 100% width. Playlist could use a bit of new philosophy and rewrite of code. I mean not necessary prevent 100% width, nothing wrong with it. But rearange things, elements, to make it more modern and fitting. I dont know, bigger thumbnail at the left of song, not at top. |
Some technical issues here:
|
I am wondering if we need to first off improve the current Audio block with among other focuses being able to use inner/child blocks as part of a Play list. Similar to Image blocks that are a part of the Image Gallery block being worked on. #25940 |
This was discussed in the Feb 3, 2021 core-editor chat (https://wordpress.slack.com/archives/C02QB2JS7/p1612363563122800): This issue is still a low priority for being implemented by the team, but the project welcomes contributions if someone has a passion for driving this issue forward. For next steps: one way to experiment, might be to start with a plugin. Note that the mock ups and approach in the summary need rethinking and updating. It may also help to close this issue and create a fresh one for clarity. |
@gwwar Closing this issue and creating a new one will simply put it back even further in the queue. At least by keeping it open you can see how long people have been waiting for this functionality. It's disappointing that feature parity with the Classic Editor isn't being made a priority before new features are implemented. People are using this functionality today, so it's sad to see that there's little priority in making their transition to Gutenberg a lot easier. Users shouldn't have to find a plugin to replace functionality that has been in the Classic Editor for years, and for functionality that users were promised that would exist in the new editor. Not only is that a really bad suggestion, but you'd be forcing people to re-edit all their past content so as to make it work with any plugin they decided to use. |
I agree with @maddisondesigns on this. The existing playlist functionality is vital part of existing music and podcast websites. New Gutenberg implementation of the playlist feature needs to be backwards compatible with existing content as much as possible. Currently, the only other options (other than 3rd party plugins) are to embed spotify or soundcloud playlists which both take users away from the site. |
Chiming in to support the request to bring back the functionality we used
to enjoy.
…On Fri, 5 Feb 2021, 10:59 pm Ralph, ***@***.***> wrote:
I agree with @maddisondesigns <https://github.com/maddisondesigns> on
this. The existing playlist functionality is vital part of existing music
and podcast websites. New Gutenberg implementation of the playlist feature
needs to be backwards compatible with existing content as much as possible.
Currently, the only other options (other than 3rd party plugins) are to
embed spotify or soundcloud playlists which both take users away from the
site.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#805 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6ELUY2SR3NMOES3MSPVCLS5O6QPANCNFSM4DLRUGRQ>
.
|
There are so many projects going on in Gutenberg. Adding a Playlist block is pretty low on that list. In the mean time use this method to add a Playlist into Gutenberg.
Add-playlist-Classic-block.mp4 |
Thanks for the playlist summary. This used to be a feature of Wordpress but as I recall, it was not working for a while. Good to see it back! |
We've been encountering use cases on WordPress.com where a block that utilizes the old playlist shortcode system would be very helpful. Especially since some themes make heavy use of the shortcodes and it is very difficult for new users to get the shortcodes they need. |
My suggestion would be for a user to be able to add links to the playlist so that files hosted elsewhere are available in the playlist block when it finally becomes available. |
Because playlist feature parity is a prerequisite to enabling the block editor for audio-oriented post types (and sites), I looked into creating block patterns with content embedded in classic blocks. This bizarrely works, and inserts a blank classic playlist "block" placeholder embedded in a classic block:
Clicking on the placeholder's edit icon opens the media modal UI for uploading/selecting media and creating the playlist. This could be added to core, or the pattern directory, as an interim improvement while we wait for a real playlist block. A downside is that if you "convert to blocks", then the inline preview goes away and you're back to a difficult-to-use shortcode block. |
Had a chat today with a someone looking for this functionality on WordPress.com - still would be great to see. The workaround we used (for their WordPress.com site) was to create a Media Playlist widget (legacy), then copy the shortcode from that widget and embed it into a page using the Shortcode block. Next time, I might end up recommending the Classic block workaround, as that may be fewer steps, and doesn't require a different area of the site (widgets + page editor). |
Given this issue has not seen movement for a long time, and the mockups are completely outdated, in order to see if it can gain traction I've added it as a suggestion for core blocks here: #58773 (comment), and close this out so when it gets traction there, we can open a new issue with fresh mockups. |
It is alarming to see this issue closed as "completed" without actually addressing the problem or providing a clear link to next steps (the linked issue above is very broad and only tangentially related). There is a fundamental disconnect here between the functionality in the classic editor and the block editor. The classic editor offers a robust media library and playlist interface to give audio content an equivalent to image galleries. Playlists were introduced to WordPress core a decade ago in WordPress 3.9; playlists were identified as a feature gap before the block editor shipped and remain missing 5+ years later. Audio-oriented sites need to know the workarounds to continue using this core feature (hidden into a "classic block"), rely on plugins, or turn to platforms other than WordPress. If the decision is to formally deprecate the playlist feature set, then that should be formally announced and documented. I'd rather see this core functionality exposed, or even better, integrated to the next iteration of the media library in an improved form. Quietly closing what was the oldest open issue in this repository without resolution has negative connotations. While it's true that the mockups (and likely the technical work toward implementation) early in this issue are outdated, that should not be the only basis for tracking issues. Closing this issue silences the many voices that have contributed to the discussion here, largely advocating for parity with the classic editor and the continued need for playlist functionality. |
Cool, reopened. |
I was looking at #50664, and could be worth exploring showing the audio waves/bars in a more predominant way. The audio results page made for Openverse and the Podcast index page for WordPress.org site have interesting designs. Here below are quick screenshots. Openverse. Audio resultsWordPress.org. Podcast index |
PlaceholderAfter audio is selected in the media libraryPlaying a songSome notes:
|
Who can provide me with the background information of and source code of this Openverse audio player? As far as I can tell, it is not a block. |
One of the folks from @WordPress/openverse-maintainers might provide more accurate info, but so far I can share the storybook component and the Openverse repo. |
@carolinan You are correct, it is not a block, the code is written in Vue, so would need to be rewritten Here is a direct link to the code for the audio track component: https://github.com/WordPress/openverse/tree/main/frontend/src/components/VAudioTrack The player works in terms of different layouts that compose shared underlying components. You can see those layouts in this part of the code: https://github.com/WordPress/openverse/tree/main/frontend/src/components/VAudioTrack/layouts Styles for Openverse's frontend are written with tailwind, so should be possible to convert 1-to-1 with SASS or CSS-in-JS (whichever WordPress blocks are using these days, it's been a while since I've looked 😅) |
@sarayourfriend we don't use React on the frontend of blocks so this would need to be rewritten anyways in plain JS or with the interactivity API. Could be a good candidate for the latter since we can ensure it integrates with client navigation if it's turned on. |
Splitting this out from #283. See also #804.
Attributes
States
Placeholder:
Neutral:
Selected:
The text was updated successfully, but these errors were encountered: