Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Block: Add "Upload / Media Library" buttons to the "Upload an Image" placeholder area. #8309

Closed
kjellr opened this issue Jul 30, 2018 · 2 comments
Closed

Gallery Block: Add "Upload / Media Library" buttons to the "Upload an Image" placeholder area. #8309

kjellr opened this issue Jul 30, 2018 · 2 comments
Assignees
@jorgefilipecosta
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.x

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 30, 2018

Is your feature request related to a problem? Please describe.

Once an image has been added to the gallery, we don't provide a straightforward way to add more images from the media library. There's a placeholder area at the bottom of the block, but that only allows you to drag+drop or click to upload a new image:

untitled

Describe the solution you'd like

We should consider adding "Upload / Media Library" buttons to the "Add an Image" placeholder area. This would align the appearance and functionality of that area with both the initial state of the gallery block, and with the standard placeholder for all other media-based blocks as well.

image
@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Jul 30, 2018
@kjellr kjellr changed the title Gallery Block: Add "Upload / Media Library" buttons to the "Add an Image" placeholder area. Gallery Block: Add "Upload / Media Library" buttons to the "Upload an Image" placeholder area. Jul 30, 2018
@kjellr kjellr mentioned this issue Jul 30, 2018
Closed
12 tasks
@kriskarkoski
Copy link

I noticed this in some recent testing as well, and +1 to that mockup. You can click the pencil to manage it and then add from the existing library from there, but it feels pretty hidden.

@noisysocks noisysocks mentioned this issue Aug 20, 2018
Closed
@noisysocks
Copy link
Member

I think this is a good idea and would help solve some of the confusion we've seen e.g. in #9121.

@kevinbazira kevinbazira mentioned this issue Sep 7, 2018
Closed
4 tasks
@paaljoachim paaljoachim mentioned this issue Nov 2, 2018
Closed
@ocean90 ocean90 added [Feature] Media Anything that impacts the experience of managing media [Block] Gallery Affects the Gallery Block - used to display groups of images labels Nov 11, 2018
@ocean90 ocean90 mentioned this issue Nov 11, 2018
Closed
@ocean90 ocean90 added this to the WordPress 5.0 milestone Nov 11, 2018
@mtias mtias modified the milestones: WordPress 5.0, WordPress 5.0.1 Nov 22, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Nov 27, 2018
@jorgefilipecosta jorgefilipecosta mentioned this issue Nov 27, 2018
Merged
@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label Nov 27, 2018
jorgefilipecosta added a commit that referenced this issue Mar 25, 2019
@jorgefilipecosta
Gallery Block: Add Media Library button to the upload new image area (#…
3c1fe58 
…12367)

Fixes: #8309
Supersedes: #9682

This PR adds a media library button in the upload new image are of the gallery block.
Trying to follow the design 2 proposed in #9682 (comment) by @kjellr and approved by @karmatosed.

A new functionality that allows the gallery to open in library/add frame instead of the edit frame was added to MediaUpload, so when the user pressed the media library button in the add zone the user goes directly to the add to library section when using the edit gallery button on the toolbar the user goes to the edit gallery section.

## Description
I added a gallery;
I added some images;
I selected the gallery;
I checked that a new media library button exists in the add to gallery zone.
If I click on it I go directly to a frame that allows the addition of images from the library to the gallery.

## How has this been tested?

## Screenshot
<img width="997" alt="screenshot 2018-11-27 at 15 35 14" src="https://user-images.githubusercontent.com/11271197/49093136-64176280-f25b-11e8-82de-ff44cee4ab47.png">
This was referenced Apr 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests
7 participants
@youknowriad @mtias @noisysocks @ocean90 @kjellr @kriskarkoski @jorgefilipecosta