Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio buttons need border-radius override #8833

Closed
chrisvanpatten opened this issue Aug 10, 2018 · 2 comments · Fixed by #8835
Closed

Radio buttons need border-radius override #8833

chrisvanpatten opened this issue Aug 10, 2018 · 2 comments · Fixed by #8835
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@chrisvanpatten
Copy link
Contributor

Since #8385 we provide an updated generic style for inputs with a default 4px border-radius. However because of the order of CSS loading, this default border-radius override's core's 50% border-radius definition for radio buttons (which renders them round).

To Reproduce
Steps to reproduce the behavior:

  1. Open a block with a <RadioControl />
  2. See it's not round

Expected behavior
Good: 🔘
Bad: ⏺

Screenshots

untitled___ mindful _wordpress
@chrisvanpatten chrisvanpatten mentioned this issue Aug 10, 2018
Merged
4 tasks
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system labels Aug 10, 2018
@karmatosed
Copy link
Member

As this is a matter of sorting loading, there wouldn't be any design change. Making that assumption lets remove design feedback just for now, happy to add back if we do want to discuss.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Aug 10, 2018
@chrisvanpatten
Copy link
Contributor Author

@karmatosed I don’t think any design feedback is needed either. There is also a pending PR at #8835 that is just waiting for Travis to get fixed up.

jasmussen pushed a commit that referenced this issue Aug 14, 2018
@chrisvanpatten @jasmussen
Apply new checkbox CSS to radio buttons and fix border radius (#8835)
1759c92 
* Apply new checkbox CSS to radio buttons w/ border-radius fix; fixes #8833

* Use $round-radius instead of 50%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply new checkbox CSS to radio buttons and fix border radius TomodomoCo/gutenberg
3 participants
@karmatosed @designsimply @chrisvanpatten