Clicking the "Keyboard Shortcuts" button in the Classic block does nothing.

[kjellr]

Describe the bug

Clicking the "Keyboard Shortcuts" button in the Classic block has no effect.

To Reproduce

1. Insert a classic editor block.
2. Expand the classic block controls to show the second line.
3. Click the question mark icon.
4. Nothing happens.

Expected behavior

It seems like (most of?) the classic editor shortcuts work, so I'd expect that the keyboard shortcuts modal shows up.

Screenshots

Tested in:
Mac OS 10.13.6, Safari 11.1.2, Chrome 69.0.3497.81

[ianbelanger79]

I can confirm that the "Keyboard Shortcuts" button does nothing when clicking on it.

Tested in Windows 10, Chrome and Firefox

[mtias]

Should we remove this button here given there's a more general one?

[chrisvanpatten]

Does the Classic block/TinyMCE have its own set of shortcuts that aren't included in Gutenberg's Keyboard Shortcuts modal?

[tofumatt]

Does the Classic block/TinyMCE have its own set of shortcuts that aren't included in Gutenberg's Keyboard Shortcuts modal?

They aren't labelled, but yes.

[karmatosed]

Should we remove this button here given there's a more general one?

To me yes this feels the right move.

@tofumatt what ones are missed and could when classic block is active those appear in the modal? I maybe am asking for a complicated check, but the idea we have 2 places for same thing here is awkward.

[tofumatt]

I don't see any keyboard shortcuts on the TinyMCE buttons:

But actually I don't see too many we're missing from https://www.tiny.cloud/docs/advanced/keyboard-shortcuts/

What you're talking about doing (having keyboard shortcuts vary based on block selection) is bad UX to me. Keyboard shortcuts should be global and the Classic Block isn't a UX I think we want to advertise, right? It taking up space in the global shortcuts just adds noise and having it contextually appear seems like a lot of added complexity for a UX that won't be clear. Would that extend to other blocks? Would a custom block be able to add to the shortcuts modal (but only when selected).

I think we should just remove the button. If the Classic Block has extra features we aren't advertising I think that's fine. Classic Block is already quite "expert mode". 🤷‍♂️

[mtias]

Related #6195.

[youknowriad]

closed in #11856