Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The WP_Block_Parser class can't be loaded in the gutenberg_parse_blocks() function #9791

Closed
imath opened this issue Sep 11, 2018 · 1 comment · Fixed by #9799
Closed

The WP_Block_Parser class can't be loaded in the gutenberg_parse_blocks() function #9791

imath opened this issue Sep 11, 2018 · 1 comment · Fixed by #9799
Assignees
@aduth
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f Needs Technical Feedback Needs testing from a developer perspective. npm Packages Related to npm packages [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Milestone
3.8

Comments

@imath
Copy link
Contributor

imath commented Sep 11, 2018 •
edited
Loading

Describe the bug
Testing 3.8RC1 with one of my plugin, I've found that the block-serialization-default-parser package was missing into the packages folder.

To Reproduce
Steps to reproduce the behavior:

  1. Download & Activate https://github.com/imath/gutenblocks/releases/tag/1.2.5
  2. Create a new post
  3. Type /dubb (or /doubl if you're french) into the default block and select the Dubber (or Doubleur if you're french) block
  4. Type anything into one of the nested blocks and wait for the Autosave to throw the error "Updating failed"
  5. Here's the output of the rest response:
Warning: require_once(PathTo\gutenberg\lib/../packages/block-serialization-default-parser/parser.php): failed to open stream:
No such file or directory in PathTo\gutenberg\lib\blocks.php on line 79

Looking into the packages folder of the 3.8 Release Candidate 1, there's no block-serialization-default-parser/parser.php file in it. See screenshot below.

Expected behavior
the gutenberg_parse_blocks() function should load the WP_Block_Parser.

Screenshots
ouchissue

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 68

Additional context
@imath imath mentioned this issue Sep 11, 2018
Closed
@mcsf mcsf mentioned this issue Sep 11, 2018
Merged
4 tasks
@aduth aduth added this to the 3.8 milestone Sep 11, 2018
@aduth aduth added the Needs Technical Feedback Needs testing from a developer perspective. label Sep 11, 2018
@ianbelanger79 ianbelanger79 added [Type] Bug An existing feature does not function as intended [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f npm Packages Related to npm packages [Type] Regression Related to a regression in the latest release Needs Technical Feedback Needs testing from a developer perspective. and removed Needs Technical Feedback Needs testing from a developer perspective. labels Sep 11, 2018
@aduth aduth self-assigned this Sep 11, 2018
@aduth aduth mentioned this issue Sep 11, 2018
Merged
@aduth
Copy link
Member

aduth commented Sep 11, 2018

Proposed fix at #9799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f Needs Technical Feedback Needs testing from a developer perspective. npm Packages Related to npm packages [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

Build Tooling: Include block serialization default parser in plugin WordPress/gutenberg
3 participants
@aduth @imath @ianbelanger79