Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Tooling: Include block serialization default parser in plugin #9799

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Build Tooling: Include block serialization default parser in plugin #9799

merged 1 commit into from
Sep 11, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 11, 2018

This should be included in a final 3.8 release.

Fixes #9791
Related: #8083

This pull request seeks to resolve an issue where the new PHP parser introduced in #8083 was not included in the plugin distributable.

Testing instructions:

Run npm run package-plugin. Ensure that the generated ZIP includes packages/block-serialization-default-parser/parser.php.

Verify there are no other non-included PHP files contained in packages:

find packages -type f -name "*.php"

@aduth aduth added [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling labels Sep 11, 2018
@aduth aduth added this to the 3.8 milestone Sep 11, 2018
@aduth aduth mentioned this pull request Sep 11, 2018
Closed
@mcsf
Copy link
Contributor

mcsf commented Sep 11, 2018

Many thanks for jumping on this so quickly.

mcsf
mcsf approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the built plugin works when interacting with a third-party plugin which calls the PHP parser, whereas it didn't before.

@aduth aduth merged commit 5febf46 into master Sep 11, 2018
@aduth aduth deleted the fix/9791-build-include-parser-php branch September 11, 2018 16:17
youknowriad pushed a commit that referenced this pull request Sep 12, 2018
@aduth @youknowriad
Build Tooling: Include block serialization default parser in plugin (#…
54f1588 
…9799)
@aduth aduth mentioned this pull request Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcsf mcsf mcsf approved these changes

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@pento pento Awaiting requested review from pento

@dmsnell dmsnell Awaiting requested review from dmsnell

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

The WP_Block_Parser class can't be loaded in the gutenberg_parse_blocks() function
2 participants
@aduth @mcsf