-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using addQueryArgs to generate Manage All Reusable Blocks link #10065
Using addQueryArgs to generate Manage All Reusable Blocks link #10065
Conversation
What's the benefit for using |
To be coherent. Then in our case, we override |
I think it's fine to land it. @SofiaSousa can you refresh this PR with the latest changes from In other places, I also see |
# Conflicts: # packages/edit-post/src/components/header/more-menu/index.js # packages/editor/src/components/inserter/menu.js
@gziolo PR has the latest changes from the I did a little search for Otherwise, I think we should replace all calls of |
I'm confused as much as you are, good finding :)
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than mentioned lock file changes, these changes look good. Thanks for refreshing.
@@ -2975,7 +2975,6 @@ | |||
"resolved": "https://registry.npmjs.org/align-text/-/align-text-0.1.4.tgz", | |||
"integrity": "sha1-DNkKVhCT810KmSVsIrcGlDP60Rc=", | |||
"dev": true, | |||
"optional": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see unrelated lock file changes in this PR. My bet is that it is because this file was regenerated using npm 6.7 which introduced some changes in a way optional
flag is handled. Can you try to run npm install
with the latest version of npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version did you mean? I had npm@6.1.0 when those "optional": true,
appeared. Tried to update to the latest (npm install -g npm@latest
) but the latest version is npm@6.7.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latest version is npm@6.7.0
This one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I misunderstood your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #13653 to fix the issue with the lock file. I tested those changes and they work as expected. Thank you for opening this PR. I will land your changes from my branch, but technically it will still get merged under your name :)
Description
Using
addQueryArgs
method from@wordpress/url
instead of hand coding 'Manage All Reusable Blocks' link.How has this been tested?
edit.php?post_type=wp_block
.edit.php?post_type=wp_block
.Screenshots
Types of changes
Reuse an existing method.
Checklist: