Style nested <ul>
s with circles instead of normal bullets
#10358
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while working on #10303 that we style nested unordered lists with a normal bullet, instead of
circle
which is more typical of user agent stylesheets (aka default browser styles).In the Chrome user agent styles, for instance, you can see the default is overridden:
This adds a rule to the editor stylesheets to handle nested styles.
Here's the before:
And here's the after:
One small implementation note: I've removed a
:not()
selector that was previously ensuring the<ul>
CSS rule did not apply to.wp-block-gallery
and instead placed an override in the gallery block's editor stylesheet.I expect this to be slightly controversial, but this is intentional to avoid a selector specificity issue. Basically,
ul:not(.wp-block-gallery)
is more specific thanol ul
. We would have had to do something likeol:not(.wp-block-gallery) ul
or whatever to increase the specificity which is kind of annoying and unnecessary. To me, this feels like a case where the gallery should manage its own overrides.