Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use permalink template filter only for wp version < 5.0.0. #10408

Conversation

rahulsprajapati
Copy link
Contributor

Description

Fixes: #10400
This is to use Gutenberg for WordPress nightly builds and trunk once core trac #45017 patch merge in it.

eventually, lib/rest-api.php will be removed entirely before WordPress 5.0.
ref: #10400 (comment)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Note: This is to use Gutenberg for WordPress nightly builds and trunk once core trac WordPress#45017 patch merge in it.
ref: WordPress#10400
@danielbachhuber
Copy link
Member

Thanks @rahulsprajapati !

Closing this for now. Before this PR is appropriate, we'll need to:

  1. Land several patches in core.
  2. Bump the WordPress version to include the latest SVN revision. The current version is 5.0-alpha-43676-src.
  3. Target the SVN revision specifically when performing the version comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants