Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding in validation modal #10441

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Fix padding in validation modal #10441

merged 1 commit into from
Oct 16, 2018

Conversation

johngodley
Copy link
Contributor

A regression in #9900 made the padding in the block validation model a bit wonky:

edit_post_ wordpress_latest _wordpress

This removes the custom validation padding CSS so it looks like:

edit_post_ wordpress_latest _wordpress

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@johngodley johngodley added [Feature] Blocks Overall functionality of blocks [Type] Regression Related to a regression in the latest release labels Oct 9, 2018
@johngodley johngodley requested a review from jasmussen October 9, 2018 14:48
jasmussen
jasmussen approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jasmussen jasmussen added this to the 4.1 milestone Oct 10, 2018
@gziolo gziolo merged commit 99100fa into master Oct 16, 2018
@gziolo gziolo deleted the fix/modal-validation branch October 16, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
4.1 - UI freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@johngodley @jasmussen @gziolo