Show the block styles in the block inspector #10543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
reviewed
Oct 12, 2018
gziolo
approved these changes
Oct 12, 2018
| { ( fills ) => ! isEmpty( fills ) && ( | ||
| <div><InspectorControls.Slot /></div> | ||
| { !! blockType.styles && ( | ||
| <div className="editor-block-inspector__styles"> |
There was a problem hiding this comment.
Minor: We put a class name inside div in here and inside PanelBody for the advanced controls. Is it possible to use a common approach? It would be nice to put it inside PabelBody as we probably will want to remove those wrapping div elements at some point. It's NOT a blocker :)
mtias
reviewed
Oct 12, 2018
| @@ -46,3 +46,7 @@ | |||
| width: $icon-button-size; | |||
| height: $icon-button-size-small; | |||
| } | |||
|
|
|||
| .editor-block-inspector__styles .editor-block-styles__item { | |||
| width: 100%; | |||
There was a problem hiding this comment.
Glad it only took this to work :)
There was a problem hiding this comment.
I love how composable Gutenberg is, one component which can be reused in so many places ❤️
Yeah :)
|
"Styles" should probably be placed at the top of all panels. |
|
After some testing decided to fit them in two columns as it makes a better use of space:
|
youknowriad
commented
Oct 12, 2018
youknowriad
force-pushed
the
add/editor-styles-inspector
branch
from
9c542bf to
4468a54
Compare
gziolo
added
[Type] Task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10520
This PR adds the styles selector to the block inspector like shown in this screenshot.