Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset TinyMCE state in live DOM after blur #10721

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

Description

Fixes #8877.

This is an alternative approach to #8879. With the new RichText value, we can simply overwrite the live DOM on blur so that any TinyMCE is removed.

How has this been tested?

See #8877.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added the [Status] In Progress Tracking issues with work in progress label Oct 18, 2018
@ellatrix ellatrix requested a review from aduth October 18, 2018 08:42
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that blur doesn't necessarily mean it's left the element (since it bubbles, vs. focusout), is there any chance a blur could occur within the field to produce an undesirable result?

Similarly, what about when a user navigates to/from a toolbar or link insertion/editing?

@ellatrix
Copy link
Member Author

Original issue seems to be resolved.

@ellatrix ellatrix closed this Nov 20, 2018
@ellatrix ellatrix deleted the try/mce-reset-dom-state-blur branch November 20, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing Flow: Pressing enter while within inline boundary forces caret position to revert
2 participants