Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Extends docs for withFilters HOC #11313

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Docs: Extends docs for withFilters HOC #11313

merged 1 commit into from
Oct 31, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 31, 2018

Description

Supersedes #10195. This PR extends documentation for the withFIlters higher-order component (HOC). It improves the code and tries to make it easier to read. It also adds an example where props can be overridden.

@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Feature] Extensibility The ability to extend blocks or the editing experience labels Oct 31, 2018
@gziolo gziolo added this to the 4.3 milestone Oct 31, 2018
@gziolo gziolo self-assigned this Oct 31, 2018
@gziolo gziolo mentioned this pull request Oct 31, 2018
Closed
4 tasks
adamsilverstein
adamsilverstein approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@gziolo gziolo merged commit 0841246 into master Oct 31, 2018
@gziolo gziolo deleted the docs/with-filters-extend branch October 31, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

@gziolo gziolo

Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @adamsilverstein