PostPublishPanel: constraint tabbing within panel #11403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
[Focus] Accessibility (a11y)
oandregal
changed the title
tofumatt
approved these changes
Nov 2, 2018
oandregal
force-pushed
the
update/publish-flow-accesibility
branch
from
f3f509f to
aff5406
Compare
|
Not that I haven't tried! But I'm struggling to see what makes Puppeteer sad. In theory, tests should be as simple as this. In practice, they are failing. The problem seems to be that focus stays and the title and doesn't change to the PostPublishPanel after it is opened - it works properly in Gutenberg across browsers. @tofumatt would you have any guess why that's failing in Puppeteer? |
oandregal
changed the title
|
Figured in 05f51f3: the post needs to have some content to be publishable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #4187 (comment)