Add aria label to images in Gallery block during edit mode. #11466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Focus] Accessibility (a11y)
|
Thank you! |
youknowriad
approved these changes
Nov 5, 2018
packages/block-library/CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| ## 2.1.8 (unreleased) | |||
There was a problem hiding this comment.
If it's a new feature, it should be 2.2.0
There was a problem hiding this comment.
Yeah, I wasn't sure as it is a small non breaking change, more of a small enhancement. Will change this tonight.
tofumatt
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11396
Description
Adds in an aria label to images in a Gallery Block during edit mode, making it easier to understand which image you are focusing while cycling through them.
How has this been tested?
Manual testing with various screen readers.
Checklist: