Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostPublishPanel: return focus to element that opened the panel #11543

Merged
merged 27 commits into from
Nov 9, 2018
Merged

PostPublishPanel: return focus to element that opened the panel #11543

merged 27 commits into from
Nov 9, 2018

Commits on Nov 9, 2018

  1. Toggle disabled if post is published

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    3044063 View commit details
    Browse the repository at this point in the history

  2. Toggle should be disabled if post is published

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    6cca773 View commit details
    Browse the repository at this point in the history

  3. Return focus to Publish... button 

    - Do not unmount Header settings components.
- Hide the "Save draft" button because it's not hidden by the
  PostPublishPanel slide-in sidebar.
    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    4bfb697 View commit details
    Browse the repository at this point in the history

  4. Sort dependencies

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    0fac6ef View commit details
    Browse the repository at this point in the history

  5. Extract props

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    3155c59 View commit details
    Browse the repository at this point in the history

  6. Add toggleProps to button

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    9228b68 View commit details
    Browse the repository at this point in the history

  7. Inline text for toggle within the button component

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    557eca0 View commit details
    Browse the repository at this point in the history

  8. Always render the button component

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    4bbcac4 View commit details
    Browse the repository at this point in the history

  9. Use aria-disabled instead of disabled to avoid focus loss

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    22a421f View commit details
    Browse the repository at this point in the history

  10. Improve comments

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    35de337 View commit details
    Browse the repository at this point in the history

  11. Update snapshots

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    c2b1a9f View commit details
    Browse the repository at this point in the history

  12. Add deprecation notice in editor CHANGELOG

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    b12e4c3 View commit details
    Browse the repository at this point in the history

  13. Add deprecation notice in plugin

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    9ba9dd4 View commit details
    Browse the repository at this point in the history

  14. Add deprecation in component

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    6956da2 View commit details
    Browse the repository at this point in the history

  15. Add DotTip to PostPublishButton

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    e310d64 View commit details
    Browse the repository at this point in the history

  16. Fix deprecation warning in tests

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    72b8e99 View commit details
    Browse the repository at this point in the history

  17. Update PostPublishButton e2e tests to use aria-disabled instead of di… 

    …sabled att
    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    0e2cae7 View commit details
    Browse the repository at this point in the history

  18. Update e2e test 

    This was relying on the preview button not being mounted
while the publish panel was opened. A better logic is to
check whether the actual publish panel is shown.
    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    2ffa78a View commit details
    Browse the repository at this point in the history

  19. Tweak comment

    @tofumatt
    tofumatt authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    57254cd View commit details
    Browse the repository at this point in the history

  20. Update version

    @nosolosw
    nosolosw authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    48439c0 View commit details
    Browse the repository at this point in the history

  21. Update packages/editor/src/components/post-publish-panel/toggle.js

    @nosolosw
    nosolosw authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    9341979 View commit details
    Browse the repository at this point in the history

  22. Place component in a separate line 

    Co-Authored-By: nosolosw <nosolosw@users.noreply.github.com>
    @tofumatt @nosolosw
    tofumatt and nosolosw authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    0ef0206 View commit details
    Browse the repository at this point in the history

  23. Update version number

    @nosolosw
    nosolosw authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    94b251f View commit details
    Browse the repository at this point in the history

  24. Add comment

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    8f50b19 View commit details
    Browse the repository at this point in the history

  25. Update comment

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    ca93215 View commit details
    Browse the repository at this point in the history

  26. Tweak comment

    @tofumatt
    tofumatt authored Nov 9, 2018
    Configuration menu
    Copy the full SHA
    99433b4 View commit details
    Browse the repository at this point in the history

  27. chore: Move deps to 4.5

    @tofumatt
    tofumatt committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    8b0d6bb View commit details
    Browse the repository at this point in the history