Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled conditions for publish buttons #11584

Merged
merged 20 commits into from
Nov 9, 2018
Merged

Disabled conditions for publish buttons #11584

merged 20 commits into from
Nov 9, 2018

Commits on Nov 8, 2018

  1. Button disabled if post isSaving 

    The test was passing due to wrong conditions.
    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    198c300 View commit details
    Browse the repository at this point in the history

  2. Button disabled if not publishable but saveable

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    df08b79 View commit details
    Browse the repository at this point in the history

  3. Button disabled if not saveable but publishable

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    b3d15e7 View commit details
    Browse the repository at this point in the history

  4. Button enabled if publishable and saveable

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    1e0bc8e View commit details
    Browse the repository at this point in the history

  5. Button disabled if forceIsSaving

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    e60f0be View commit details
    Browse the repository at this point in the history

  6. Button: make forceIsDirty condition obvious

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    1d7eebf View commit details
    Browse the repository at this point in the history

  7. Toggle disabled when isSaving

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    d143273 View commit details
    Browse the repository at this point in the history

  8. Toggle disabled when forceIsSaving

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    df2796c View commit details
    Browse the repository at this point in the history

  9. Toggle clarify forceIsDirty conditions

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    c89ce08 View commit details
    Browse the repository at this point in the history

  10. Toggle disabled if not saveable

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    7f1a6bf View commit details
    Browse the repository at this point in the history

  11. Toggle disabled if post is published

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    7e4c72a View commit details
    Browse the repository at this point in the history

  12. Toggle & Button better test description

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    363978d View commit details
    Browse the repository at this point in the history

  13. Button should be disabled if post saving is locked

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    dcc095f View commit details
    Browse the repository at this point in the history

  14. Button is disabled if post is saving or forceIsSaving

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    fa480ab View commit details
    Browse the repository at this point in the history

  15. Toggle is enabled if isSaveable and one of isPublishable or forceIsDi… 

    …rty is true
    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    2355bf1 View commit details
    Browse the repository at this point in the history

  16. Button busy only if post is published

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    6f56d29 View commit details
    Browse the repository at this point in the history

  17. Toggle should be disabled if post is published

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    f9ad64a View commit details
    Browse the repository at this point in the history

  18. Button - refactor for clarity

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    ca0cda4 View commit details
    Browse the repository at this point in the history

  19. Toggle - refactor for readability

    @oandregal
    oandregal committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    4075b57 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Add e2e tests

    @oandregal
    oandregal committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    3495c58 View commit details
    Browse the repository at this point in the history