Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: Improve columns block #11620

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Try: Improve columns block #11620

merged 2 commits into from
Nov 9, 2018

Commits on Nov 8, 2018

  1. Try: Improve columns block 

    This PR aims to improve the column block usability, as well as fix a few issues:

1. It makes the individual columns unclickable by using pointer events. Since these are not actionable yet, being able to select them is not really helpful.

2. It improves the UI around reusable blocks, by fixing an issue where even though contents should be disabled when in a reusable block, it was still selectable if there were nested blocks.

3. It further improves the reusable block UI by fixing a regression where the reusable block editing bar did not push down content sufficiently.

4. It refactors how margins in the columns block work, to be simpler and more predictable, and makes it behave similar to every other block in that regard.
    @jasmussen
    Joen Asmussen authored and jasmussen committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    db30ce6 View commit details
    Browse the repository at this point in the history

  2. Improve the margins of an empty colums block.

    @jasmussen
    jasmussen committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    205d0d8 View commit details
    Browse the repository at this point in the history