-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update image loading state to use a spinner and a faded static image. #11876
Conversation
0689b7f
to
c76ec28
Compare
Nice! I pushed up c76ec28 which applies the same effect to the Gallery block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good improvement 👍
There's also the media and text block that could do with this improvement (that doesn't seem to have any loading state at all, which I found confusing as a user).
Thinking into the future, I wonder if there's more that can be abstracted out of the media blocks (in terms of placeholders, loading state, toolbar buttons) so that they don't have separate but very similar implementations.
Ah, interesting. It looks like
Moving the |
Thanks for including galleries and merging!
I agree. Ideally a block developer only has to use a |
The current implementation of "this image is being uploaded" uses a heavy pulsating effect that has not proven to be very clear but it has been distracting.
This simply removes that effect and shows a spinner at the center — consistent with how Embeds are working — while leaving the image faded out until upload completes.
Related #8810.