-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichText: mark onSplit as unstable #11926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad That's probably fine, RichText is entirely different there as well, handling the onSplit prop. |
Ideally they should align because the goal is that plugin author using |
I'm merging this, let's make sure we follow-up with what's needed for mobile. |
Late to the party but, @daniloercoli , @diegoreymendez can you check if there are things we need to do or update for the gutenberg-mobile side? Thanks! |
I've created a new issue for this gutenberg-mobile side, since we want to port the changes above to mobile. Probably in the beta Milestone. |
Description
onSplit
is an being revised in #11005, but it's not sure when we can land this change. In the meantime it would be good to markonSplit
as unstable. It's a relatively small deprecation. I don't expect many non core blocks to use this prop. Even in core we only use it for 3 blocks.How has this been tested?
Screenshots
Types of changes
Checklist: