Fix regression with Sibling Inserter. #11969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sibling inserter is the plus you see when you hover between two blocks. When you have no blocks selected, or use the unified toolbar mode. you can access the sibling inserter between any two blocks. When you have a block selected, and have the block-affixed toolbars, only the sibling inserter below the selected block should be availabl e. Though it should still be keyboard accessible. This PR fixes that.
jasmussen
added
[Type] Bug
There was a problem hiding this comment.
Hi @jasmussen, this works correctly in most of the cases. The only case where the problem still exists is if spotlight mode is enabled.
I think the problem happens because in this mode is-selected class is not added.
|
Great catch, thank you Jorge. Pushed a fix for spotlight mode. |
gziolo
added
the
[Priority] High
|
Everything is fine in my testing. Only a small gotcha with the columns block, the inserter for the columns block (not individual columns, but the whole block) is slightly covered by the column block toolbar :
|
youknowriad
approved these changes
Nov 19, 2018
This was referenced Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sibling inserter is the plus you see when you hover between two blocks.
When you have no blocks selected, or use the unified toolbar mode. you can access the sibling inserter between any two blocks.
When you have a block selected, and have the block-affixed toolbars, only the sibling inserter below the selected block should be availabl
e. Though it should still be keyboard accessible.
This PR fixes that.
Before:
After: