Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(synchronizeBlocksWithTemplate): Fix, merge template attributes on update #12406

Closed
wants to merge 1 commit into from
Closed

fix(synchronizeBlocksWithTemplate): Fix, merge template attributes on update #12406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/blocks/src/api/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ export function synchronizeBlocksWithTemplate( blocks = [], template ) {
return map( template, ( [ name, attributes, innerBlocksTemplate ], index ) => {
const block = blocks[ index ];

if ( block && block.name === name ) {
const innerBlocks = synchronizeBlocksWithTemplate( block.innerBlocks, innerBlocksTemplate );
return { ...block, innerBlocks };
}

// To support old templates that were using the "children" format
// for the attributes using "html" strings now, we normalize the template attributes
// before creating the blocks.
Expand Down Expand Up @@ -97,6 +92,11 @@ export function synchronizeBlocksWithTemplate( blocks = [], template ) {
attributes
);

if ( block && block.name === name ) {
const innerBlocks = synchronizeBlocksWithTemplate( block.innerBlocks, innerBlocksTemplate );
return { ...block, attributes: normalizedAttributes, innerBlocks };
}

return createBlock(
name,
normalizedAttributes,
Expand Down