Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a post is saved, check for tinymce and save any editors. #12568

Merged
merged 8 commits into from
Dec 9, 2018
Merged

When a post is saved, check for tinymce and save any editors. #12568

merged 8 commits into from
Dec 9, 2018

Conversation

ideadude
Copy link
Contributor

@ideadude ideadude commented Dec 3, 2018

Description

This is an alternative fix to this PR: #12363

The other pull request imported tinymce and ran tinymce.triggerSave(); but this wasn't actually saving the editor content in some cases.

This patch instead checks for window.tinymce and if found loops through the editors individually and calls the save() method of the editors. This will copy the tinymce editor content into the related textarea so the updated content is saved. Importantly, if the editor is on the text tab, the save method will NOT copy the tinymce content and instead leave the textarea as is. In other words, with this PR things are working as expected: the content from whichever tab (visual or text) that is visible will be saved.

Another note: this PR doesn't import the tinymce library or include the other updates the referenced PR had. This isn't needed, since we just use the window.tinymce object as is if it's found.

How has this been tested?

This was tested on WP 4.9.9-alpha-43656 and Chrome Version 70.0.3538.110 (Official Build) (64-bit). I tested on Firefox v63.

I tested this in a number of ways. I tested on new pages and posts. I tested updated the visual or text tabs. I tested with multiple editors from multiple plugins. I tested with the classic editor installed. I tested when saving a draft or publishing or clicking update.

All my tests passed.

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

(Note: There were other warnings in the file I changed that I ignored.)

  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ideadude ideadude mentioned this pull request Dec 3, 2018
Closed
youknowriad
youknowriad reviewed Dec 4, 2018
View reviewed changes
packages/edit-post/src/store/effects.js Outdated
@@ -72,6 +72,13 @@ const effects = {
} );
},
REQUEST_META_BOX_UPDATES( action, store ) {
// Saves the wp_editor fields
if ( window.tinymce ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will have the same effect but I'd use import tinymce from "tinymce" for consistency in how we use the tinymce module accross gutenberg.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the same. That will hold all the editor instances of all the rich text instances. window.tinymce holds the instances that were created by plugins and the classic block. Should this filter out classic block instances?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. in the classic block we set a property to editor and then check for it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR to import tinymce and use that vs the object stored in window.tinymce. This does have the effect of including the classic editor tinymce instances in .editors. Calling the save method on the classic block tinymce instances doesn't seem to have any adverse effects though (besides a minor performance hit). IMO it's not worth filtering them out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going crazy here. I did a quick test of swapping back triggerSave vs the looping and it's working again. Going to do some more tests with the old PR to really figure out why that was failing for me sometimes again.

I'm afk for a couple hours, but will post an update soon. :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the meta boxes were added with window.tinymce? The nom module is only used for RichText instances. We don't want to include them here. window.tinymce.editors does not include the RichText TinyMCE instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI my madness is that tinyMCE.triggerSave() --caps MCE-- works. The alternative PR had just tinymce.triggerSave() --lower mce-- which doesn't work.

I think using window.tinymce is safer with regards to the fix here. I feel like tinyMCE.editors was not always returning all of the added wp_editor boxes in some cases. Not sure the conditions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import tinymce from "tinymce" and window.tinymce are strictly equivalent according to our webpack config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, here is the code in core WordPress that makes sure we don't run save on editors on the text tab: https://github.com/WordPress/WordPress/blob/master/wp-includes/js/tinymce/plugins/wordpress/plugin.js#L605-L609

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I didn't see any rich text editor instances, so I thought they were different. Apparently rich text TinyMCE are not being added. Strange.

@youknowriad
Copy link
Contributor

Can we bring the package.json and changelog tweaks from https://github.com/WordPress/gutenberg/pull/12363/files too?

ellatrix
ellatrix reviewed Dec 4, 2018
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs e2e tests.

@ideadude
Copy link
Contributor Author

ideadude commented Dec 4, 2018 •
edited
Loading

Updated the version in package.json and changelog.md. Let me know if I did this incorrectly. I'm confused by the empty sections for certain versions in the changelog.md. Is there a write up on how these components are versioned?

3 options left for the actual code here:

  1. import tinymce and use tinyMCE.triggerSave()

  2. import tinymce and loop through tinyMCE.editors

  3. don't import tinymce and loop through window.tinymce.editors

Edit:

Adding a 4th that the current PR is using. Don't import tinymce, use tinyMCE.triggerSave()

A variation of this would be to use window.tinyMCE.triggerSave() to make sure we are talking about the "global" tinyMCE.

youknowriad
youknowriad reviewed Dec 4, 2018
View reviewed changes
packages/edit-post/src/store/effects.js Outdated
@@ -72,6 +73,11 @@ const effects = {
} );
},
REQUEST_META_BOX_UPDATES( action, store ) {
// Saves the wp_editor fields
for ( var i = 0; i < tinyMCE.editors.length; i++ ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this means you're loading the tinymce variable but using the tinyMCE global? seems to me like we should replace this with tinymce to use the imported variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the global tinyMCE without importing tinymce at the top.

If we import tinymce and call tinymce.triggerSave or tinymce.editors, they don't work as we would expect to save the extra editors.

Thanks again for the time on this. We're going to fix this issue, which is important for plugins. I'm getting an education in Gutenberg, node, and JS here. I apologize for the confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help here :). That's interesting though, now I'm curious. What is the difference between window.tinymce and window.tinyMCE?

Copy link
Contributor Author

@ideadude ideadude Dec 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.tinymce and window.tinyMCE seem to be the same object in my console (or 2 copies of the same object in sync). TinyMCE might setup both???

@ideadude
Copy link
Contributor Author

ideadude commented Dec 6, 2018

This is ready to pull in IMO.

rilwis added a commit to wpmetabox/meta-box that referenced this pull request Dec 6, 2018
@rilwis
Fixed wysiwyg field not saving in Gutenberg.
dad4d0b 
Bug report: https://metabox.io/support/topic/data-are-not-saved-into-the-database/
Issue: WordPress/gutenberg#7176

The fix is based on CMB2 fix (CMB2/CMB2#1190) and the PR(WordPress/gutenberg#12568)

When the PR is merged into core/Gutenberg, this fix should be removed.
youknowriad
youknowriad reviewed Dec 8, 2018
View reviewed changes
packages/edit-post/package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@wordpress/edit-post",
"version": "3.1.4",
"version": "3.1.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "3.1.5",
"version": "3.1.4",

The versions are actually changed automatically when we publish the packages. So we should keep it as is and only update the change log for now

pbrocks
pbrocks approved these changes Dec 9, 2018
View reviewed changes
Copy link

@pbrocks pbrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing as-is the Metabox did not save using the Visual tab.
gutenberg-not-saving

When I added the window.tinyMCE.triggerSave(); snippet it did save.
gutenberg-metabox-saving

@youknowriad youknowriad added this to the 4.7 milestone Dec 9, 2018
@pbrocks
Copy link

pbrocks commented Dec 9, 2018

This comment confirms that the capitalization of the tinyMCE made a difference. In this screencast I tested lowercase first.
case-sensitive-tinymce

@youknowriad youknowriad merged commit 4ea5094 into WordPress:master Dec 9, 2018
@youknowriad youknowriad mentioned this pull request Dec 9, 2018
Closed
pinarol added a commit that referenced this pull request Dec 11, 2018
@pinarol
Merge master into mobile (#12796)
5821ec7 
* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
@mtias mtias added [Feature] Meta Boxes A draggable box shown on the post editing screen [External Package] TinyMCE labels Dec 13, 2018
Tug added a commit that referenced this pull request Dec 13, 2018
@Tug
Merge 'origin/master' into 'origin/mobile' (#12836)
e81aecf 
* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json
youknowriad pushed a commit that referenced this pull request Dec 19, 2018
@Tug @youknowriad
Get the last mobile changes back in master (#12582)
170f2a8 
* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText
@staurand staurand mentioned this pull request Jan 4, 2019
Open
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
@Tug @youknowriad
Get the last mobile changes back in master (#12582)
fb041d7 
* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
@Tug @youknowriad
Get the last mobile changes back in master (#12582)
daba72b 
* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText
@aduth aduth mentioned this pull request Jan 18, 2019
Closed
@aduth
Copy link
Member

aduth commented Jan 21, 2019

As noted at #12942 (comment) , calling save on a TinyMCE editor has the consequence resetting the caret position. With the changes introduced here, this can be demonstrated by pressing Ctrl+S in a paragraph field to save the post while a meta box is present on the editor screen (#12942 (comment)).

rilwis added a commit to wpmetabox/meta-box that referenced this pull request Jan 8, 2021
@rilwis
Remove code to ensure tinymce save
d29f498 
PR: WordPress/gutenberg#12568
File: https://github.com/WordPress/gutenberg/blob/master/packages/edit-post/src/store/actions.js#L333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix left review comments

@pbrocks pbrocks pbrocks approved these changes

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ideadude @youknowriad @pbrocks @aduth @ellatrix @mtias