Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Fix deleting text when deleting the next image block #1257

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Blocks: Fix deleting text when deleting the next image block #1257

merged 1 commit into from
Jun 19, 2017

Conversation

youknowriad
Copy link
Contributor

closes #1252

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Jun 19, 2017
@youknowriad youknowriad self-assigned this Jun 19, 2017
@jasmussen
Copy link
Contributor

Nice! Works for me! 👍 👍

@youknowriad youknowriad merged commit 6c745d1 into master Jun 19, 2017
@youknowriad youknowriad deleted the fix/backspace-delete-image-and-text branch June 19, 2017 10:22
@aduth
Copy link
Member

aduth commented Jun 19, 2017

I can no longer backspace in text blocks because of this change.

I think we need to be more specific about when we're calling preventDefault. In one or the other or both of the two conditions?

@youknowriad youknowriad mentioned this pull request Jun 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting: Pressing backspace while an image is selected deletes preceding text
3 participants
@youknowriad @jasmussen @aduth