Display Saving label while save in progress #1301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707
Related: #1203
This pull request seeks to resolve a regression introduced in #1203 where the "Saving" label is no longer shown in the header while a save is in progress. The issue is due to the fact that when a save begins, post edits are cleared, meaning that the post is considered un-saveable (no title, content, or excerpt). Due to the order of logic in
SavedState
, this resulted in nothing been shown, instead of the "Saving" label, despite a save being in progress.Implementation notes:
Should we really be clearing post edits when a save is initiated? My thinking is that we should optimistically persist them as being the current state of the post. cc @youknowriad
Testing instructions:
Verify that a Saving label is shown after clicking Save in the editor bar, while the request is in progress. Using Chrome Developer Tools network throttling to emulate a slower connection can help identify the change in label.