Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clickOnMoreMenuItem not dependent on aria labels #13166

Conversation

jorgefilipecosta
Copy link
Member

The clickOnMoreMenuItem end 2 end test util was dependent on aria labels being present on each menu item.
This aria labels are redundant and just duplicate the inner text menu item, they will be removed as soon as #12955 is merged.
This PR updates an end 2 end test util that relied on this aria labels being present.
This way we will make sure tests pass on #12955 as soon as this PR is merged.

How has this been tested?

I verified the end 2 end tests pass.
I reverted all snapshot updates in #12955 and merge that PR with this and I checked the end 2 end tests continue to pass.

@jorgefilipecosta jorgefilipecosta added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jan 2, 2019
@jorgefilipecosta jorgefilipecosta self-assigned this Jan 2, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this change in to unblock the issue referenced 👍

`/*[contains(concat(" ", @class, " "), " components-menu-item__info-wrapper ")][contains(text(), "${ buttonLabel }")]`
) );
}
expect( elementToClick ).not.toBeFalsy();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line is really required? It might fail on the next line regardless.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line was removed 👍

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 31, 2019
@jorgefilipecosta jorgefilipecosta force-pushed the update/clickOnMoreMenuItem-not-dependent-on-aria-label branch from dfe24eb to ad56763 Compare January 31, 2019 15:40
@jorgefilipecosta jorgefilipecosta force-pushed the update/clickOnMoreMenuItem-not-dependent-on-aria-label branch from ad56763 to cb8031c Compare January 31, 2019 15:41
@jorgefilipecosta jorgefilipecosta merged commit bebda20 into master Jan 31, 2019
@jorgefilipecosta jorgefilipecosta deleted the update/clickOnMoreMenuItem-not-dependent-on-aria-label branch January 31, 2019 16:17
daniloercoli added a commit that referenced this pull request Feb 1, 2019
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg:
  Try alternate list item jump fix. (#12941)
  Mobile bottom sheet component (#13612)
  Remove unintentional right-margin on last odd-item. (#12199)
  Introduce left and right float alignment options to latest posts block (#8814)
  Fix Google Docs table paste (#13543)
  Increase bottom padding on gallery image caption (#13623)
  Fix the editor save keyboard shortcut not working in code editor view (#13159)
  Plugin: Deprecate gutenberg_add_admin_body_class (#13572)
  Rnmobile/upload media failed state (#13615)
  Make clickOnMoreMenuItem not dependent on aria labels (#13166)
  Add: className prop support to server side render. (#13568)
  Fix: Categories Block: hierarchical Dropdown (#13567)
  Docs: Add clarification about git workflow (#13534)
  Plugin: Remove `user_can_richedit` filtering (#13608)
  eslint-plugin: Add rule `no-unused-vars-before-return` (#12828)
  Image settings button (#13597)
  Fixed wording for the color picker saturation (#13479)

# Conflicts:
#	packages/block-library/src/image/edit.native.js
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
The clickOnMoreMenuItem end 2 end test util was dependent on aria labels being present on each menu item.
This aria labels are redundant and just duplicate the inner text menu item, they will be removed as soon as #12955 is merged.
This commit updates an end 2 end test util that relied on this aria labels being present.
This way we will make sure tests pass on #12955 as soon as this PR is merged.

## How has this been tested?
I verified the end 2 end tests pass.
I reverted all snapshot updates in #12955 and merge that PR with this and I checked the end 2 end tests continue to pass.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
The clickOnMoreMenuItem end 2 end test util was dependent on aria labels being present on each menu item.
This aria labels are redundant and just duplicate the inner text menu item, they will be removed as soon as #12955 is merged.
This commit updates an end 2 end test util that relied on this aria labels being present.
This way we will make sure tests pass on #12955 as soon as this PR is merged.

## How has this been tested?
I verified the end 2 end tests pass.
I reverted all snapshot updates in #12955 and merge that PR with this and I checked the end 2 end tests continue to pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants