Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve castError handling of non strings #13315

Merged
merged 10 commits into from
Jan 23, 2019

Commits on Jan 19, 2019

  1. improve handling of non strings for errors

    - introduce ReduxRoutineResponseError, a custom error handler for non string error values.  The “response” is added to a `response` property on this new error handler thus exposing arbitrary responses to any client code wanting to extract from.
    - implement ReduxRoutineResponseError in `castError` so that this error object is always returned when the error value is not already an instance of Error.
    nerrad committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    0ca25d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82df7b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    612eb3f View commit details
    Browse the repository at this point in the history
  4. woops use * not mixed

    nerrad committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    3bfd2f4 View commit details
    Browse the repository at this point in the history
  5. add change-log entry

    nerrad committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    803f848 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8c14ed1 View commit details
    Browse the repository at this point in the history
  7. update tests and changelog

    nerrad committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    d087742 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Update packages/redux-routine/CHANGELOG.md

    Co-Authored-By: nerrad <darren@roughsmootheng.in>
    aduth and nerrad authored Jan 22, 2019
    Configuration menu
    Copy the full SHA
    5452aba View commit details
    Browse the repository at this point in the history
  2. tweak changelog

    nerrad committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    f448674 View commit details
    Browse the repository at this point in the history
  3. simplify logic

    nerrad committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    3c9f1d4 View commit details
    Browse the repository at this point in the history