Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example usage for MediaPlaceholder #13389

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jan 20, 2019

Description

Adds an example of how to use the MediaPlaceholder and setting
the url for an image attribute.

Fixes #13377

How has this been tested?

Documentation.

To test, follow example and see if it works for placing a MediaPlaceholder component.

Adds an example of how to use the MediaPlaceholder and setting
the url for an image attribute.

Fixes #13377
@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Jan 20, 2019
@mkaz mkaz self-assigned this Jan 20, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted some spaces in the usage example to be aligned with JS coding styles.

LGTM 👍

@mkaz mkaz merged commit 6d5a537 into master Jan 21, 2019
@gziolo gziolo added this to the Documentation & Handbook milestone Jan 22, 2019
@gziolo gziolo deleted the docs/13377/media-placeholder branch January 22, 2019 09:19
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Add example usage for MediaPlaceholder

Adds an example of how to use the MediaPlaceholder and setting
the url for an image attribute.

Fixes #13377

* Fixed code style
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Add example usage for MediaPlaceholder

Adds an example of how to use the MediaPlaceholder and setting
the url for an image attribute.

Fixes #13377

* Fixed code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants