Docs: Move packages section out of CONTRIBUTING.md #13418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
commented
Jan 22, 2019
| @@ -244,15 +124,15 @@ If you'd like to contribute to the design or front-end, feel free to contribute | |||
|
|
|||
| Documentation is automatically synced from master to the [Gutenberg Documentation Website](https://wordpress.org/gutenberg/handbook/) every 15 minutes. | |||
|
|
|||
| To add a new documentation page, you'll have to create a Markdown file in the [docs](https://github.com/WordPress/gutenberg/tree/master/docs) folder and add an item to the [root-manifest.json](https://github.com/WordPress/gutenberg/blob/master/docs/root-manifest.json). | |||
| To add a new documentation page, you'll have to create a Markdown file in the [docs](https://github.com/WordPress/gutenberg/tree/master/docs) folder and add an item to the [toc.json](/docs/toc.json). | |||
There was a problem hiding this comment.
Is it toc.json now? It has changed and I tried to figure out based on the tool which generated the manifest file.
There was a problem hiding this comment.
You are right it is toc.json, the manifest is now generated.
ajitbohra
approved these changes
Jan 22, 2019
|
This looks good, I have a PR that changes up the contributors handbook here: #13352 but I only modified this document a little. Go ahead and land this one and I can rebase and update. |
mkaz
approved these changes
Jan 22, 2019
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Docs: Move packages section out of CONTRIBUTING.md * Update precommit hook to look at new toc.json file
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Docs: Move packages section out of CONTRIBUTING.md * Update precommit hook to look at new toc.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CONTRIBUTING.mdhas become quite big. This PR extracts the part about managing packages to its own file to make the guidelines more focused on the onboarding experience.I also update internal links to follow the same patterns we started to apply recently.