Plugin: Avoid setting generic "Edit Post" title on load #13552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Gutenberg Plugin
danielbachhuber
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
However, this behavior was never incorporated into WordPress 5.0, and in retrospect, I don't know that it adds much value. To me, there is likely to be little confusion caused from a user seeing "Add New Post" in the title of a screen if they had in-fact started their editing session by creating a new post. In any case, an enhancement here should probably be proposed to core proper, as most PHP is being removed from the Gutenberg plugin when deferring to core is possible.
Fair enough. I started creating a core ticket just now to port this over but, when I reviewed the current behavior, I agree with your assessment. We can leave the existing behavior as-is.
daniloercoli
added a commit
that referenced
this pull request
Jan 30, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (36 commits) Fixes plural messages POT generation. (#13577) Typo fix (#13595) REST API: Remove oEmbed proxy HTML filtering (#13575) Removed unnecessary className attribute. Fixes #11664 (#11831) Add changelog for RSS block (#13588) Components: Set type=button for TabPanel button elements. (#11944) Update util.js (#13582) Docs: Add accessbility specific page (#13169) Rnmobile/media methods refactor (#13554) chore(release): publish chore(release): publish Plugin: Deprecate gutenberg_get_script_polyfill (#13536) Block API: Parse entity only when valid character reference (#13512) RichText: List: fix indentation (#13563) Plugin: Deprecate window._wpLoadGutenbergEditor (#13547) Plugin: Avoid setting generic "Edit Post" title on load (#13552) Plugin: Populate demo content by default content filters (#13553) RichText: List: Fix getParentIndex (#13562) RichText: List: Fix outdent with children (#13559) Scripts: Remove npm run build from test-e2e default run (#13420) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #8831 (786de1e)
This pull request seeks to remove special handling for the admin screen's
<title>element by Gutenberg. As part of removing client-side title handling in #8831, logic was added to explicitly assign "Edit Post" (or as defined by custom post type label) as the title of the screen, regardless whether the user was adding a new post or editing an existing one. Presumably this was added to account for the fact that due to the lack of full page reload on save, a user would seamlessly transition from the state of adding a new post to editing an existing one.However, this behavior was never incorporated into WordPress 5.0, and in retrospect, I don't know that it adds much value. To me, there is likely to be little confusion caused from a user seeing "Add New Post" in the title of a screen if they had in-fact started their editing session by creating a new post. In any case, an enhancement here should probably be proposed to core proper, as most PHP is being removed from the Gutenberg plugin when deferring to core is possible.
Testing instructions:
Verify that page titles of the post editor, both in adding a new post and editing an existing one, align between the Gutenberg plugin and in the block editor provided through WordPress 5.0.
Specifically, a new post should show "Add New Post", and editing an existing post should show "Edit Post".