-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ellipsis to post title placeholder #13627
Add ellipsis to post title placeholder #13627
Conversation
Thanks for the PR. Back in the day, we did have ellipses for both Add Title and even the "Write your story..." prompt. It was a specific design decision to remove those. I can't recall the exact circumstances, and it's proving hard to find this in the archive. But simply for the reason of not going back on a past decision, this needs more thoughts. |
Just noting that it goes against changes proposed in #12473 and discussed in #1659. @afercia - what's the recommendation from the accessibility team?
This goes against what @timwright12 proposes in #12473. |
Yeah I think we worked all this out in the other PR when we rewrote the labels. |
Noting that the title is also set on PHP side in the plugin: https://github.com/WordPress/gutenberg/blob/master/lib/client-assets.php#L1157 that's why I can't see this change applied in the editor. I'm not sure if this is the case in WordPress core, too. |
I am not totally sure what '...' gives to the engagement. I think this is a case of we have done it in past so keep doing it. I'd love to get some opinions on this and how it impacts engagement. |
From a stylistic point of view, I'd tend to lean away from the ellipses. It makes it feel rather like an incomplete command or unfinished thought, rather than a suggestion that trails off. An ellipses also implies that the user would complete the sentence, but what happens instead is that the user replaces the sentence immediately. Do we have a voice and tone guide for UI text? That could help guide this discussion if we have specific principles we're following. |
As mentioned above that they were purposefully removed at one point, I'd like to keep inline with that thinking. I haven't found any documentation on wp.org to support this decision, but I did rummage through Material Design documentation for text fields and placeholders of which they never use an ellipsis. In fact, in their Sass mixin docs, they mention that an ellipsis is used to truncate text, which we're not doing here. I also looked at Google Forms and noticed they don't use ellipsis either. This whole practice seems much cleaner to me. I'm opting to close this PR in favor of #12473. |
Description
Placeholders usually have an ellipsis at the end. See the end of this comment.
This PR adds an ellipsis to the post title placeholder in the editor.