Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "we" from messages #13644

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Remove "we" from messages #13644

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e848c9
remove "we" from embed preview error message
Rahmon Feb 2, 2019
e369335
remove "we" from embed placeholder
Rahmon Feb 2, 2019
b432338
Change from "embed" to "embedded".
Rahmon Feb 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/embed/embed-placeholder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const EmbedPlaceholder = ( props ) => {
</Button>
{ cannotEmbed &&
<p className="components-placeholder__error">
{ __( 'Sorry, we could not embed that content.' ) }<br />
{ __( 'Sorry, this content could not be embed.' ) }<br />
Copy link
Contributor

@Aurorum Aurorum Feb 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this makes sense as is. It makes me think twice, personally I'd prefer the use of the word "embedded" for consistency with the other message and because it's more frequently used.

Suggested change
{ __( 'Sorry, this content could not be embed.' ) }<br />
{ __( 'Sorry, this content could not be embedded.' ) }<br />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated. Thanks for show me this mistake. I'm not native/fluent english speaker >.<

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for updating! :)

It looks great to me now.

<Button isLarge onClick={ tryAgain }>{ _x( 'Try again', 'button label' ) }</Button> <Button isLarge onClick={ fallback }>{ _x( 'Convert to link', 'button label' ) }</Button>
</p>
}
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/embed/embed-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const EmbedPreview = ( props ) => {
{ ( cannotPreview ) ? (
<Placeholder icon={ <BlockIcon icon={ icon } showColors /> } label={ label }>
<p className="components-placeholder__error"><a href={ url }>{ url }</a></p>
<p className="components-placeholder__error">{ __( 'Sorry, we cannot preview this embedded content in the editor.' ) }</p>
<p className="components-placeholder__error">{ __( 'Sorry, this embedded content cannot be previewed in the editor.' ) }</p>
</Placeholder>
) : embedWrapper }
{ ( ! RichText.isEmpty( caption ) || isSelected ) && (
Expand Down