Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Make placeholder text working on RichText #13699

Merged

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Feb 6, 2019

This PR does fix an issue where the placeholder text wasn't working fie on RichText for mobile.

The issue was noticed and reported since the Title block is now using the RichText component, but the problem was there on other blocks already. See Para and Heading.

Not sure when we broke it, but i guess long time ago.
Now the placeholder is visible on Para/Heading/Title blocks.

GB-mobile side PR is here: wordpress-mobile/gutenberg-mobile#544

@daniloercoli daniloercoli added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 6, 2019
@daniloercoli
Copy link
Contributor Author

As per chat convo I removed the this.props.placeholder check, and run this PR with wp-android try editing an already published post, and a new post. Also tried on gb-mobile.

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest merged commit 9e1d20e into master Feb 7, 2019
@hypest hypest deleted the rnmobile/make-placeholder-text-working-on-richtext-mobile branch February 7, 2019 11:52
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Make placeholder text working again on RichText

* Make sure the native side is always refreshed when the RichText component is cleared

* Remove placeholder check
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Make placeholder text working again on RichText

* Make sure the native side is always refreshed when the RichText component is cleared

* Remove placeholder check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants