-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry-aware controls #13722
Add registry-aware controls #13722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
This all seems sensible to me, but I've got some burrowed worry about how this actually works, when we'd have some separate |
@aduth That's a good point, I thought about it and yes it's challenging if we map the selectors and controls inside the store creation funciton. It means the I think this should be reconsidered as part of the "clone" implementation and whether the performance gain in long posts is important enough to be worth the added complexity. |
ea64095
to
8b07508
Compare
Related #13662 Requirement for #13088
In some situations, you want to build controls that target another store from the registry. Until now we were relying on the global
select
ordispatch
functions but the issue is that it only targets the default registry. If we have a separate provider, this might not work as expected. In this PR, I'm introducing acreateRegistryControl
helper used to mark a control a cross-stores control with access to the registry object.This PR also includes a follow-up performance improvement to the registry-aware selectors.