Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meta box docs #13733

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Update meta box docs #13733

merged 1 commit into from
Feb 8, 2019

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Feb 7, 2019 •
edited
Loading

Follow-up to #13544

To correctly reflect the current behavior and that there is no such thing as a fallback.

@oandregal oandregal requested a review from pento February 7, 2019 12:24
@oandregal oandregal self-assigned this Feb 7, 2019
@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Feature] Meta Boxes A draggable box shown on the post editing screen labels Feb 7, 2019
@oandregal oandregal added this to the Documentation & Handbook milestone Feb 7, 2019
@oandregal oandregal mentioned this pull request Feb 7, 2019
Merged
aduth
aduth approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up. This reads well to me, though as evidenced by my misunderstanding of the compatibility that had been implemented as part of the 5.0 release, I'll leave it to you to decide whether a second opinion is warranted 😅

mkaz
mkaz approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second opinion 👍

@oandregal oandregal merged commit 9d51c3e into master Feb 8, 2019
@oandregal oandregal deleted the update/meta-box-docs branch February 8, 2019 08:53
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@nosolosw @youknowriad
Update docs (#13733)
e9a7f28
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@nosolosw @youknowriad
Update docs (#13733)
b8a6ec0
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
This was referenced May 1, 2020
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@mkaz mkaz mkaz approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@notnownikki notnownikki Awaiting requested review from notnownikki

@youknowriad youknowriad Awaiting requested review from youknowriad

@pento pento Awaiting requested review from pento

Assignees

@oandregal oandregal

Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Documentation & Handbook
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @mkaz @aduth