Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely hide the meta boxes icons from screen readers #1388

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Completely hide the meta boxes icons from screen readers #1388

merged 1 commit into from
Jun 28, 2017

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jun 23, 2017

Fixes a Firefox/NVDA bug where the aria-expanded state change doesn't get announced when SVG icons are updated on the fly. To test:

  • using Firefox and NVDA on master, tab to one of the metaboxes toggle buttons
  • activate the button pressing Spacebar or Enter to toggle the meta box
  • observe how NVDA doesn't announce "expanded" or "collapsed"
  • switch to this branch and repeat the steps above
  • observe how NVDA correctly announces "expanded" or "collapsed"

Screenshot:

screenshot 109

Fixes #1387.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 23, 2017
@jasmussen
Copy link
Contributor

To me this seems fine to merge. 👍

@afercia afercia merged commit 67cf1b9 into master Jun 28, 2017
@afercia afercia deleted the update/meta-boxes-svg-icons-a11y branch June 28, 2017 09:15
@jasmussen jasmussen mentioned this pull request Jun 28, 2017
Merged
@jasmussen
Copy link
Contributor

My apologies, I approved this too soon (and reverted in #1537).

Can we add the aria-hidden attribute on the SVG element itself? And if so, should we do it upstream in https://github.com/WordPress/dashicons?

This was referenced Jun 28, 2017
Closed
Closed
@afercia afercia mentioned this pull request Mar 16, 2019
Closed
youknowriad pushed a commit that referenced this pull request Jan 17, 2020
@lukewalczak
Fix lint issue on rmobile/master on gutenberg repo (#1388)
82ce8df 
* Add ref to gutenberg repo

* Update ref and revert gitmodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afercia @jasmussen