Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only expose the select function in registry selectors #13889

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Only expose the select function in registry selectors #13889

merged 1 commit into from
Feb 15, 2019

Conversation

youknowriad
Copy link
Contributor

This PR updates the API of the registry selector to only receive "select" instead of "registry" to match withSelect API.

@youknowriad youknowriad added the [Package] Data /packages/data label Feb 15, 2019
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
@youknowriad youknowriad self-assigned this Feb 15, 2019
nerrad
nerrad approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a couple things:

  • Need a CHANGELOG.md entry?
  • Should there be something in the README.md about this or are you holding off until it's been in use for a bit?

@youknowriad
Copy link
Contributor Author

Need a CHANGELOG.md entry?

Probably not since it's the same as the previous one

Should there be something in the README.md about this or are you holding off until it's been in use for a bit?

This pattern of cross-stores dependencies is required but not sure yet if we should encourage it. It certainly deserves to be in an "Advanced" section in the data module docs.

aduth
aduth approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I considered whether createRegistrySelector is still the best name to describe its purpose. I think it works well enough still.

@youknowriad youknowriad merged commit af68f20 into master Feb 15, 2019
@youknowriad youknowriad deleted the update/registry-selectors-to-only-expose-select branch February 15, 2019 15:08
This was referenced Feb 18, 2019
Merged
Merged
Closed
youknowriad added a commit that referenced this pull request Mar 6, 2019
@youknowriad
Only expose the select function in registry selectors (#13889)
135dc69
youknowriad added a commit that referenced this pull request Mar 6, 2019
@youknowriad
Only expose the select function in registry selectors (#13889)
1a96974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@nerrad nerrad nerrad approved these changes

@gziolo gziolo Awaiting requested review from gziolo

@noisysocks noisysocks Awaiting requested review from noisysocks

Assignees

@youknowriad youknowriad

Labels
[Package] Data /packages/data
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @nerrad @aduth