-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add ability to transform audio shortcodes to audio blocks #14045
[Enhancement] Add ability to transform audio shortcodes to audio blocks #14045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the code and it appears to work perfect.
Created a post with the classic editor and added a paragraph and an audio shortcode. Opening the post with the block editor and converting results in the audio shortcode transformed in an audio block that preserves the settings of the audio shortcode.
This might need to be rebased for the e2e tests. |
Thank you so much for the rebase @youknowriad ❤️. Sincere apologies as I couldn't make it, it was a hectic week 😞 |
No worries, it's fine :) Thanks for the PR and I hope to see a lot more :) |
THANK YOU SO MUCH 😍 |
Description
This PR adds the ability to transform
[audio]
shortcodes to audio blocks, like the gallery and caption shortcodes have.How has this been tested?
This PR has been tested by going through the following steps:
[audio]
shortcode to the content, e.g.[audio src="https://gutenberg.local/wp-content/uploads/2018/12/snow.mp3"]
Screenshots
Types of changes
This PR follows the shortcode transformation structure of the gallery and caption blocks and implements them accordingly in the audio block.
Checklist: