Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using left borders for hover + selection states #14145

Merged
merged 38 commits into from
Mar 15, 2019
Merged

Try using left borders for hover + selection states #14145

merged 38 commits into from
Mar 15, 2019

Commits on Feb 27, 2019

  1. Add thick borders to the left of blocks when they're hovred + selected.

    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    7441319 View commit details
    Browse the repository at this point in the history

  2. Add thick left border to the page title.

    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    583223c View commit details
    Browse the repository at this point in the history

  3. Turn off block toolbar centering for alignwide blocks. 

    This splits the left border in two, which looks a bit weird.
    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    021232b View commit details
    Browse the repository at this point in the history

  4. Move block breadcrump to the left side, position it on top of the block.

    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    3723174 View commit details
    Browse the repository at this point in the history

  5. Clean up the block toolbar's left border.

    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    56a8edb View commit details
    Browse the repository at this point in the history

  6. Use inset borders on mobile.

    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    77cf04b View commit details
    Browse the repository at this point in the history

  7. Prevent inset borders from overlapping with full-bleed content.

    @kjellr
    kjellr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    65fafa4 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Use a gray border instead of a blue one on hover.

    @kjellr
    kjellr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b9c6259 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Use a sass variable to define the left block border width

    @youknowriad
    youknowriad committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    5a076a1 View commit details
    Browse the repository at this point in the history

  2. Fix breadcrumb potision for alignfull blocks.

    @kjellr
    kjellr committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    bfa8039 View commit details
    Browse the repository at this point in the history

  3. Clean up breadcrumb position for left & right-aligned blocks.

    @kjellr
    kjellr committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    8b927e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Sync block mover animation up with the hover state.

    @kjellr
    kjellr committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    b958f40 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into try/left-block-borders

    @kjellr
    kjellr committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    bf457e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Merge branch 'master' into try/left-block-borders

    @kjellr
    kjellr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    2009f9c View commit details
    Browse the repository at this point in the history

  2. Darken focused block borders slightly. 

    From $light-gray-500 to $light-gray-800.
    @kjellr
    kjellr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    4024095 View commit details
    Browse the repository at this point in the history

  3. Switch to using border instead of outline for block borders. 

    Also, change the thick left border to a solid color, to prevent weird overlap.
    @kjellr
    kjellr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    c1de2bd View commit details
    Browse the repository at this point in the history

  4. Make this work better with Windows High Contrast Mode

    @kjellr
    kjellr committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    f4468b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Adjust z-index of border + breadcrumb for child blocks. 

    So that they're not overlapped by the parent block's border + toolbar.
    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    7f52808 View commit details
    Browse the repository at this point in the history

  2. Remove extra z-index rule from the block border. 

    Turns out this wasn't needed anyway.
    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    a658491 View commit details
    Browse the repository at this point in the history

  3. Remove extra z-index rule from the block border. Minor description cl… 

    …eanup.
    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    2b41bb8 View commit details
    Browse the repository at this point in the history

  4. Ensure these styles are compatible with Top Toolbar mode.

    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    bdcedbc View commit details
    Browse the repository at this point in the history

  5. Use the new gray value for the mobile toolbar border.

    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    ea4e64e View commit details
    Browse the repository at this point in the history

  6. Add a matching left border to the post permalink area above the title.

    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    130d84f View commit details
    Browse the repository at this point in the history

  7. Improve border position for mobile screens, especially for elements t… 

    …hat float left/right.
    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    047e1e4 View commit details
    Browse the repository at this point in the history

  8. Remove a couple unnecessary border updates from 047e1e4. 

    Turns out these styles can be preserved on all screen sizes with no ill effect.
    @kjellr
    kjellr committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    8109dfa View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Clean up bugs related to the hover + focus states of the classic edit… 

    …or block.
    @kjellr
    kjellr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    147f151 View commit details
    Browse the repository at this point in the history

  2. Classic Block toolbar icon cleanup. 

    Even out margins, remove white background.
    @kjellr
    kjellr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    95ae7d9 View commit details
    Browse the repository at this point in the history

  3. Reusable Block border cleanup.

    @kjellr
    kjellr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    30a2801 View commit details
    Browse the repository at this point in the history

  4. Keeping a light border on the classic block when it's inactive.

    @kjellr
    kjellr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    82560f9 View commit details
    Browse the repository at this point in the history

  5. Clean up borders on warning blocks.

    @kjellr
    kjellr committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    f6da176 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Merge branch 'master' into try/left-block-borders

    @kjellr
    kjellr committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    36b0441 View commit details
    Browse the repository at this point in the history

  2. Switch to a solid color border color for the permalink box. 

    This mirrors the approach we use for block toolbars, and also ensures that we don't layer opacities and make the permalink toolbar darker than intended.
    @kjellr
    kjellr committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    11489aa View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Merge branch 'master' into try/left-block-borders

    @kjellr
    kjellr committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    023dc6c View commit details
    Browse the repository at this point in the history

  2. Update z-index rule name to match the one used in the latest merge.

    @kjellr
    kjellr committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    e0ae429 View commit details
    Browse the repository at this point in the history

  3. Combine full-wide toolbar centering rules. 

    Previously, these were declared in two separate palces.
    @kjellr
    kjellr committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    12e5368 View commit details
    Browse the repository at this point in the history

  4. Add a darker hover state for dark themes.

    @kjellr
    kjellr committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    c3b6c3b View commit details
    Browse the repository at this point in the history

  5. Remove the left toolbar border on mobile screens. 

    This fixes some visual bugs with themes like TwentyNineteen, which include margins on either side of the block on mobile.
    @kjellr
    kjellr committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    9b5325f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into try/left-block-borders

    @kjellr
    kjellr committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    3c744b6 View commit details
    Browse the repository at this point in the history