Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository.directory linting rule (fixes #13947) #14200

Merged
merged 8 commits into from
Mar 4, 2019
Merged

Add repository.directory linting rule (fixes #13947) #14200

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c725a0
Add repository.directory rule to npm-package-json-lint-config (fix #1…
Mar 1, 2019
3c0588c
Merge branch 'master' into add/repository-directory-lint
Mar 1, 2019
4f714d0
Fix lock file (props @aduth)
Mar 1, 2019
1898368
Fix rule, update changelogs
Mar 1, 2019
cc6040f
Add PR reference
Mar 1, 2019
aa3d180
Add directory field to packages/docgen
Mar 1, 2019
3efaa28
Apply changes suggested by @ntwb
Mar 3, 2019
c180aa0
Update CHANGELOG.md
gziolo Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 107 additions & 69 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/docgen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"homepage": "https://github.com/WordPress/gutenberg/tree/master/packages/docgen/README.md",
"repository": {
"type": "git",
"url": "git+https://github.com/WordPress/gutenberg.git"
"url": "git+https://github.com/WordPress/gutenberg.git",
"directory": "packages/docgen"
},
"bugs": {
"url": "https://github.com/WordPress/gutenberg/issues"
Expand Down
8 changes: 7 additions & 1 deletion packages/npm-package-json-lint-config/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
## v1.1.3 (2018-09-05)
## 1.2.0 (2019-03-01)
greatislander marked this conversation as resolved.
Show resolved Hide resolved

### New Feature

- The `npm-package-json-lint` peer dependency has been updated from requiring `^3.3.1` to requiring `^3.6.0`, adding [a rule which enforces the presence of the `repository.directory` field](https://github.com/tclindner/npm-package-json-lint/pull/106) [#14200](https://github.com/WordPress/gutenberg/pull/14200)
greatislander marked this conversation as resolved.
Show resolved Hide resolved

## 1.1.3 (2018-09-05)

### Bug Fix

Expand Down
1 change: 1 addition & 0 deletions packages/npm-package-json-lint-config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ const defaultConfig = {
'require-private': 'off',
'require-publishConfig': 'off',
'require-repository': 'error',
'require-repository-directory': 'error',
greatislander marked this conversation as resolved.
Show resolved Hide resolved
'require-scripts': 'off',
'require-version': 'error',
'scripts-type': 'error',
Expand Down
2 changes: 1 addition & 1 deletion packages/npm-package-json-lint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"main": "index.js",
"peerDependencies": {
"npm-package-json-lint": ">=3.3.1"
"npm-package-json-lint": ">=3.6.0"
},
"publishConfig": {
"access": "public"
Expand Down
1 change: 1 addition & 0 deletions packages/scripts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- Added support for `build` script ([#12837](https://github.com/WordPress/gutenberg/pull/12837))
- Added support for `start` script ([#12837](https://github.com/WordPress/gutenberg/pull/12837))
- The bundled `npm-package-json-lint` dependency has been updated from requiring `^3.3.1` to requiring `^3.6.0`, adding [a rule which enforces the presence of the `repository.directory` field](https://github.com/tclindner/npm-package-json-lint/pull/106) [#14200](https://github.com/WordPress/gutenberg/pull/14200)
greatislander marked this conversation as resolved.
Show resolved Hide resolved

### Bug Fix

Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"eslint": "^5.12.1",
"jest": "^24.1.0",
"jest-puppeteer": "^4.0.0",
"npm-package-json-lint": "^3.3.1",
"npm-package-json-lint": "^3.6.0",
"puppeteer": "1.6.1",
"read-pkg-up": "^1.0.1",
"resolve-bin": "^0.4.0",
Expand Down