Polish placeholders, inserter, responsiveness #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
reviewed
Jun 26, 2017
| @@ -210,7 +210,7 @@ class VisualEditorBlockList extends Component { | |||
| type="text" | |||
| readOnly | |||
| className="editor-visual-editor__placeholder" | |||
| value={ ! blocks.length ? __( 'Write your story.' ) : __( 'Write…' ) } | |||
| value={ ! blocks.length ? __( 'Write your story' ) : __( 'Write…' ) } | |||
There was a problem hiding this comment.
I added the punctuation before :)
There was a problem hiding this comment.
Hmmm you prefer with the period? For me that seems so finite especially when you're just about to blog.
There was a problem hiding this comment.
It feels weird to see sentences in the content without punctuation, but I'm willing to concede.
There was a problem hiding this comment.
I'd be okay with an ellipsis instead of a period. But it's just double ellipsi then...
This normalizes the color with placeholder text, and polishes the alignment a little.
Hide movers and config toolbars on the side. These will be resurfaced as part of a separate effort in #705.
Needs more work.
jasmussen
force-pushed
the
polish/placeholders-inserter-other
branch
from
82880ad
to
13e2178
Compare
youknowriad
pushed a commit
that referenced
this pull request
Jan 17, 2020
Enable media-text in all builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a number of things. It normalizes the color of the "new post" placeholders and inserter:
Tweak the alignment of the inserter a little.
Frees up further space on mobile for more toolbar space.
Hides the movers and config buttons on mobile. This is pending further improvement in #705, where I need to first investigate the potential accessibility implications.