Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exculde test files when rebuilding packages #14468

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

Jackie6
Copy link
Contributor

@Jackie6 Jackie6 commented Mar 15, 2019

Description

Fix #11799

How has this been tested?

  • Local
  • unit tests
  • Local e2e tests
  • Browser testing

Types of changes

Use regular expressions to exclude test files including .js files inside of tests or test folders and files with a suffix of .test or .spec (e.g. blocks.test.js) such webpack will not rebuild these files when watching some changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo requested a review from mcsf March 18, 2019 11:26
@gziolo gziolo added [Type] Build Tooling Issues or PRs related to build tooling [Type] Enhancement A suggestion for improvement. labels Mar 18, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great in my testing. Thanks for working on this PR.

@gziolo
Copy link
Member

gziolo commented Mar 18, 2019

By the way, it looks like the message printed on the console is also wrong. I didn't rename any file but I added a few modifications.

I see that this issue self-resolved. It was probably an issue with one of the used dependencies.

@gziolo gziolo merged commit cff0acf into WordPress:master Mar 18, 2019
@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 18, 2019
@gziolo
Copy link
Member

gziolo commented Mar 18, 2019

@Jackie6 congrats on your first merged code contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't rebuild packages when test file gets updated
2 participants