Fix the webpack shortcode config

[youknowriad]

closes #14436

The shortcode script has a default export, which means it should be included in the LibraryExportDefaultPlugin webpack config.

[ellatrix]

Hm, does that fix it for you? I still have the same error on this branch.

[youknowriad]

@ellatrix make sure to re-run npm run dev after switching to this branch.

[ellatrix]

@youknowriad Ah, stupid of me. :) It works, but why is this not on for all modules? Any way this can be automatic so we cannot make the same mistake with other packages?

[youknowriad]

@ellatrix I don't really know how this plugin works if there's no "default" export, will it create an empty object by default? If It's the case I think it's fine to use it by default for all packages. cc @gziolo and @aduth might know more.

[gziolo]

this["wp"] = this["wp"] || {}; this["wp"]["deprecated"] =
/******/ (function(modules) { // webpackBootstrap
...
/******/ })["default"];
//# sourceMappingURL=index.js.map

It adds this ["default"] stuff at the end of the file. I guess we could tweak it somehow different to avoid maintaining a whitelist.

For reference, a package which doesn't use default:

this["wp"] = this["wp"] || {}; this["wp"]["date"] =
/******/ (function(modules) { // webpackBootstrap
...
/******/ });
//# sourceMappingURL=index.js.map

Something like this might work as well:

"default" in module && module = module["default"]

[ellatrix]

@gziolo That would be great!

[gziolo]

Yes, @aduth made a good point last week. We should optimize the code to avoid any lists of exceptions for packages. I removed one of them from Jest config last week. That should be the next one to fix.

[aduth]

I'm still curious why this would have suddenly become a regression, if shortcode has always had a default export since July 2018, and LibraryExportDefaultPlugin has never been configured to include 'shortcode'.

[aduth]

Is it possible that we're running into a conflict between the two versions of wp.shortcode (script handles wp-shortcode vs. shortcode)?

https://github.com/WordPress/wordpress-develop/blob/6d2f78d9bacf931fb9d4ba031e135c4eb5b17713/src/js/_enqueues/wp/shortcode.js

[youknowriad]

I'd think it's the opposite. Both scripts supposed to have the exact same API (copy/paste). I think we may have never loaded the Gutenberg shortcode script and started doing so recently.

[aduth]

@youknowriad Right, I could imagine that being the case. If they're meant to be drop-in replaceable, then I imagine it shouldn't be an issue, but worth keeping an eye on further possible regressions. It makes me wonder if we couldn't also just replace the existing script from core with this new one, if it behaves the same (i.e. keep shortcode script handle for compatibility, but point it to wp-shortcode).

[youknowriad]

@aduth Right!, I had a patch at some point, worth revisiting https://core.trac.wordpress.org/ticket/44987