Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Clarify usage of @wordpress/babel-plugin-import-jsx-pragma with WordPress Babel preset #14530

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Docs: Clarify usage of @wordpress/babel-plugin-import-jsx-pragma with WordPress Babel preset #14530

merged 1 commit into from
Mar 20, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Mar 20, 2019

Description

Follow-up for #14482.

It's another try to clarify the usage of @wordpress/babel-plugin-import-jsx-pragma with WordPress Babel preset. This time it is reworded to age well according to the recommendation from @aduth shared in #14482 (comment) and this part in particular:

To me, the perfect scenario would be that the plugin gracefully handles the case that it's included twice. The next best thing would be a clear note that the preset and plugin cannot be used in combination. Re-reading this text, I think it's fairly clear. It may have just been that the phrases "now" and "anymore" caught my attention as sounding temporary and not associated with any sense of when "now" actually occurred. "As of vX.X.X" might have served as an alternative pinned to a specific point in time.

@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Tool] Babel plugin import JSX pragma /packages/babel-plugin-import-jsx-pragma labels Mar 20, 2019
@gziolo gziolo self-assigned this Mar 20, 2019
@gziolo gziolo mentioned this pull request Mar 20, 2019
Merged
aduth
aduth approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 20, 2019
@gziolo gziolo merged commit 27c0d00 into master Mar 20, 2019
@gziolo gziolo deleted the update/docs-babel-plugin-import-jsx-pragma branch March 20, 2019 14:51
This was referenced Apr 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@oandregal oandregal Awaiting requested review from oandregal

@ntwb ntwb Awaiting requested review from ntwb

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@gziolo gziolo

Labels
[Tool] Babel plugin import JSX pragma /packages/babel-plugin-import-jsx-pragma [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
5.4 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @aduth