Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/docgen url symbol #14656

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Remove/docgen url symbol #14656

merged 2 commits into from
Mar 27, 2019

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Mar 27, 2019

It suffers from a few problems:

Rendering in Github Rendering in the handbook
symbol-github symbol-handbook

It suffers from a few problems:

- relative URLs don't work on Gutenberg handbook and npm packages
- the <> is escaped so is rendered in a weird way that looks like
  an error
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix it in another PR 👍

@oandregal oandregal merged commit 557dca7 into master Mar 27, 2019
@oandregal oandregal deleted the remove/docgen-url-symbol branch March 27, 2019 10:17
@youknowriad youknowriad added this to the 5.4 (Gutenberg) milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Docgen /packages/docgen [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants