Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore proper radio button appearance on desktop screens. #14684

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Mar 28, 2019

#14624 mistakenly used negative pixel values for the position of the dot inside of radio buttons. This PR restores the correct values.

Before
Screen Shot 2019-03-28 at 8 52 56 AM

After
Screen Shot 2019-03-28 at 8 52 34 AM

PR #14624 mistakenly used negative pixel values for the position of the dot inside of radio buttons. This PR restores the correct values, to ensure proper placement.
@kjellr kjellr added the [Type] Bug An existing feature does not function as intended label Mar 28, 2019
@kjellr kjellr self-assigned this Mar 28, 2019
@kjellr kjellr requested a review from jasmussen March 28, 2019 12:56
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you Kjell!

@jasmussen jasmussen added this to the 5.4 (Gutenberg) milestone Mar 28, 2019
@kjellr kjellr merged commit 91b0c41 into master Mar 28, 2019
@kjellr kjellr deleted the fix/radio-button-appearance branch March 28, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants