Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TextControl design documentation #14710

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Update TextControl design documentation #14710

merged 4 commits into from
Mar 29, 2019

Conversation

davewhitley
Copy link
Contributor

@davewhitley davewhitley commented Mar 29, 2019

Initial commit to update TextControl readme. These changes add design documentation.

Description

This PR adds design guideline documentation in addition to the development documentation that existed previously. These guidelines are 'best practices' for the usage of the component, as well as describing the component in more detail.

Screenshots

A preview can be seen here, although it doesn't represent what it will look like in the handbook:

preview

Feedback

I'd appreciate feedback on:

  • Whether my markdown syntax is correct
  • Design guidelines
  • Double-checking a11y of the document
  • Seeing if the design guidelines align with the development documentation

Thank you!

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @drw158! I made a couple very minor fixes/markdown edits, but this is good to go. 👍

@kjellr kjellr merged commit 580fedd into master Mar 29, 2019
@kjellr kjellr deleted the update/textcontrol-doc branch March 29, 2019 19:53
@youknowriad youknowriad added this to the 5.4 (Gutenberg) milestone Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants