Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Package JSON Lint Config: Remove is-plain-obj dependency #14751

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 1, 2019

Previously: #7556

This pull request seeks to use Lodash's isPlainObject instead of the standalone is-plain-obj package. This is intended to consolidate to reduce the overall number of packages we depend upon for the project.

Testing Instructions:

Verify unit tests pass:

npm run test-unit

@aduth aduth added the [Type] Code Quality Issues or PRs that relate to code quality label Apr 1, 2019
@aduth aduth requested a review from ntwb April 1, 2019 16:00
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was is-plain-obj initially used due to concern about the unnecessary size of the 'lodash' dependency?

@aduth
Copy link
Member Author

aduth commented Apr 1, 2019

@nerrad It was originally part of the WordPress/packages repository, which didn't ever have Lodash as a dependency. I might imagine it could have been an argument in favor against the size of pulling in Lodash. In the current situation, we already have it, and this should serve as a net decrease in dependency load (though, as it turns out by transitive dependencies, the is-plain-obj is still brought in).

@aduth aduth merged commit 70cc953 into master Apr 1, 2019
@aduth aduth deleted the remove/is-plain-obj-dependency branch April 1, 2019 19:41
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants